aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorslaren <slarengh@gmail.com>2023-05-12 15:40:53 +0200
committerGitHub <noreply@github.com>2023-05-12 15:40:53 +0200
commit553fd4d4b5f3314f338be8006f62a4fdf7670186 (patch)
treed7a19612183f0d78a40db6d28ea778477823bb1f
parent089b1c93ba2b93bc9a605af293730a028fad2c4e (diff)
Add clang-tidy reviews to CI (#1407)
-rw-r--r--.clang-tidy18
-rw-r--r--.github/workflows/tidy-post.yml20
-rw-r--r--.github/workflows/tidy-review.yml23
3 files changed, 61 insertions, 0 deletions
diff --git a/.clang-tidy b/.clang-tidy
new file mode 100644
index 0000000..1a42b9a
--- /dev/null
+++ b/.clang-tidy
@@ -0,0 +1,18 @@
+---
+Checks: >
+ bugprone-*,
+ -bugprone-easily-swappable-parameters,
+ -bugprone-implicit-widening-of-multiplication-result,
+ -bugprone-narrowing-conversions,
+ readability-*,
+ -readability-avoid-unconditional-preprocessor-if,
+ -readability-function-cognitive-complexity,
+ -readability-identifier-length,
+ -readability-implicit-bool-conversion,
+ -readability-magic-numbers,
+ -readability-uppercase-literal-suffix,
+ clang-analyzer-*,
+ -clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling,
+ performance-*,
+ portability-*,
+FormatStyle: none
diff --git a/.github/workflows/tidy-post.yml b/.github/workflows/tidy-post.yml
new file mode 100644
index 0000000..a58da0c
--- /dev/null
+++ b/.github/workflows/tidy-post.yml
@@ -0,0 +1,20 @@
+name: clang-tidy review post comments
+
+on:
+ workflow_run:
+ workflows: ["clang-tidy-review"]
+ types:
+ - completed
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+
+ steps:
+ - uses: ZedThree/clang-tidy-review/post@v0.13.0
+ # lgtm_comment_body, max_comments, and annotations need to be set on the posting workflow in a split setup
+ with:
+ # adjust options as necessary
+ lgtm_comment_body: ''
+ annotations: false
+ max_comments: 25
diff --git a/.github/workflows/tidy-review.yml b/.github/workflows/tidy-review.yml
new file mode 100644
index 0000000..a4bc8d9
--- /dev/null
+++ b/.github/workflows/tidy-review.yml
@@ -0,0 +1,23 @@
+name: clang-tidy-review
+
+on:
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ clang-tidy-review:
+ runs-on: ubuntu-latest
+
+ steps:
+ - uses: actions/checkout@v3
+
+ - uses: ZedThree/clang-tidy-review@v0.13.0
+ id: review
+ with:
+ lgtm_comment_body: ''
+ build_dir: build
+ cmake_command: cmake . -B build -DCMAKE_EXPORT_COMPILE_COMMANDS=on
+ split_workflow: true
+
+ - uses: ZedThree/clang-tidy-review/upload@v0.13.0