diff options
| author | Ivan Komarov <Ivan.Komarov@dfyz.info> | 2023-04-20 17:15:18 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-04-20 18:15:18 +0300 |
| commit | 6a9661ea5ad72166b700ae5e87976e4452499dda (patch) | |
| tree | 1adc1585e54643795d1b73f49c63ee857067a6d0 | |
| parent | 5addcb120cf2682c7ede0b1c520592700d74c87c (diff) | |
ci : remove the LLAMA_ACCELERATE matrix dimension from Ubuntu builds in the CI (#1074)
[Accelerate](https://developer.apple.com/documentation/accelerate) is an Apple framework which can only be used on macOS, and the CMake build [ignores](https://github.com/ggerganov/llama.cpp/blob/master/CMakeLists.txt#L102) the `LLAMA_ACCELERATE` variable when run on non-Apple platforms. This implies setting `LLAMA_ACCELERATE` is a no-op on Ubuntu and can be removed.
This will reduce visual noise in CI check results (in addition to reducing the number of checks we have to run for every PR). Right now every sanitized build is duplicated twice for no good reason (e.g., we have `CI / ubuntu-latest-cmake-sanitizer (ADDRESS, Debug, ON)` and `CI / ubuntu-latest-cmake-sanitizer (ADDRESS, Debug, OFF)`).
| -rw-r--r-- | .github/workflows/build.yml | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 2208f42..7e8a29b 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -81,7 +81,6 @@ jobs: matrix: sanitizer: [ADDRESS, THREAD, UNDEFINED] build_type: [Debug, Release] - accelerate: [ON, OFF] steps: - name: Clone @@ -99,7 +98,7 @@ jobs: run: | mkdir build cd build - cmake .. -DLLAMA_SANITIZE_${{ matrix.sanitizer }}=ON -DCMAKE_BUILD_TYPE=${{ matrix.build_type }} -DLLAMA_ACCELERATE=${{ matrix.accelerate }} + cmake .. -DLLAMA_SANITIZE_${{ matrix.sanitizer }}=ON -DCMAKE_BUILD_TYPE=${{ matrix.build_type }} cmake --build . --config ${{ matrix.build_type }} - name: Test |