aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSam Spilsbury <smspillaz@gmail.com>2023-08-09 23:47:42 +0300
committerGitHub <noreply@github.com>2023-08-09 22:47:42 +0200
commit916a9acdd0a411426690400ebe2bb7ce840a6bba (patch)
tree130a88da78296d03f0116554a31da4fcfe821850
parentea04a4ca1940d92becc0ee26523aa2c4a18cf938 (diff)
ggml-alloc: Don't try to re-use buffers of external tensors (#2562)
* ggml-alloc: Don't try to re-use buffers of external tensors They might be weights that came from another context, so we have no control over them (and they might be re-used elsewhere so writing to them would be a bad idea). * ggml-alloc: >= when checking for out-of-bounds Co-authored-by: slaren <slarengh@gmail.com> --------- Co-authored-by: slaren <slarengh@gmail.com>
-rw-r--r--ggml-alloc.c8
1 files changed, 8 insertions, 0 deletions
diff --git a/ggml-alloc.c b/ggml-alloc.c
index 5e1be61..4121f3d 100644
--- a/ggml-alloc.c
+++ b/ggml-alloc.c
@@ -394,6 +394,14 @@ static void allocate_node(struct ggml_allocr * alloc, struct ggml_tensor * node)
if (parent == NULL) {
break;
}
+
+ // if the node's data is external, then we cannot re-use it
+ if ((char *) parent->data < (char *) alloc->data ||
+ (char *) parent->data >= ((char *) alloc->data + alloc->size)) {
+ AT_PRINTF("not reusing parent %s for %s as %p is external\n", parent->name, node->name, parent->data);
+ continue;
+ }
+
struct hash_node * p_hn = hash_get(ht, parent);
if (parent->data != NULL && p_hn->n_children == 1 && p_hn->n_views == 0 && ggml_are_same_layout(node, parent)) {
if (ggml_is_view(parent)) {