diff options
author | 0xspringtime <110655352+0xspringtime@users.noreply.github.com> | 2023-06-13 15:37:54 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-06-13 22:37:54 +0300 |
commit | 92549202659fc23ba9fec5e688227d0da9b06b40 (patch) | |
tree | 9d33ba103a4c8f30009218f35a7a8ad358f1e992 /examples/baby-llama | |
parent | e32089b2c20b1b87b22912f4a8b93fe01647d5b9 (diff) |
baby-llama : fix operator!= (#1821)
* Update baby-llama.cpp
Seems to be an error in the implementation of the operator!= function. It attempts to compare the this pointer (a llama_hparams_lora object) with the other pointer (a llama_hparams object) using memcmp. This can lead to incorrect results because the sizes of the objects being compared (sizeof(llama_hparams) and sizeof(llama_hparams_lora)) are different, should now be able to compare two llama_hparams_lora objects for inequality.
* Update baby-llama.cpp
* Update baby-llama.cpp
Diffstat (limited to 'examples/baby-llama')
-rw-r--r-- | examples/baby-llama/baby-llama.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/examples/baby-llama/baby-llama.cpp b/examples/baby-llama/baby-llama.cpp index e5639da..0add6ad 100644 --- a/examples/baby-llama/baby-llama.cpp +++ b/examples/baby-llama/baby-llama.cpp @@ -153,8 +153,8 @@ struct llama_hparams_lora { uint32_t n_rot = 64; uint32_t n_lora = 64; - bool operator!=(const llama_hparams & other) const { - return memcmp(this, &other, sizeof(llama_hparams)); + bool operator!=(const llama_hparams_lora & other) const { + return memcmp(this, &other, sizeof(llama_hparams_lora)) != 0; } }; |